Fix parsing xpath that has mult without surrounding spaces#321
Closed
tompng wants to merge 1 commit into
Closed
Conversation
Fix PathExpr's implementation to match its source code comments. Fixes parsing xpath such as `/a[(1+2)*3]`.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the XPath parser to better handle multiplication (*) and whitespace/adjacent-asterisk cases, and adds regression tests to validate equivalent parsing with/without spaces.
Changes:
- Added parser tests covering multiplication and tricky
*spacing/adjacent-token cases. - Adjusted
PathExprparsing flow to treat unconsumed input as aLocationPathand handle/-prefixed continuations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/parser/test_xpath.rb | Adds regression tests for * operator parsing with varying whitespace/adjacent * tokens. |
| lib/rexml/parsers/xpathparser.rb | Tweaks PathExpr control flow to route unconsumed input into LocationPath, impacting how adjacent * tokens are interpreted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+594
to
+596
| if rest == path | ||
| rest = LocationPath(rest, n) | ||
| else |
| def test_mult_and_spaces | ||
| parser = REXML::Parsers::XPathParser.new | ||
| assert_equal(parser.parse("1 * 2 * 3"), parser.parse("1*2*3")) | ||
| assert_equal(parser.parse("a[( ( 1 + 2 ) * 3 + 4 * ( 5 + 6 ) ) * 7 < 8]"), parser.parse("a[((1+2)*3+4*(5+6))*7<8]")) |
Member
Author
|
Closing because #322 is better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PathExpr's implementation to match its source code comments. Fixes parsing xpath such as
/a[(1+2)*3].Source code comment:
Actual implementation was:
LocationPath was eating the mult operator
*aschildaxis.